Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App registry step #24

Merged
merged 15 commits into from
Sep 13, 2024
Merged

App registry step #24

merged 15 commits into from
Sep 13, 2024

Conversation

suprjinx
Copy link
Collaborator

@suprjinx suprjinx commented Sep 10, 2024

Support AppRegistry for refreshing domain info stored locally

Fixes #17
Fixes #18

end
end

def get_domain_info(fqdn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we follow a pattern of making these class methods instead of instance methods? The calling code looked weird to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the advantage of using instance is you get the initialize method to do some setup first -- but it's definitely possible to manage this with class or module (eg, singleton instance on class to do the work)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems more Railsy to do it the singleton way, ie User.first etc etc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converted these to class-method interfaces

app/interactors/authorize_request.rb Show resolved Hide resolved
app/lib/services/auth_service.rb Outdated Show resolved Hide resolved
app/lib/services/domain_ownership_service.rb Outdated Show resolved Hide resolved
@suprjinx suprjinx merged commit 8d7236e into G-Research:main Sep 13, 2024
2 checks passed
@suprjinx suprjinx deleted the app-registry-step branch September 13, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants