-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App registry step #24
Conversation
end | ||
end | ||
|
||
def get_domain_info(fqdn) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we follow a pattern of making these class methods instead of instance methods? The calling code looked weird to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the advantage of using instance is you get the initialize
method to do some setup first -- but it's definitely possible to manage this with class or module (eg, singleton instance on class to do the work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems more Railsy to do it the singleton way, ie User.first etc etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
converted these to class-method interfaces
Support AppRegistry for refreshing domain info stored locally
Fixes #17
Fixes #18